On 2023/08/08 23:54, Florian Westphal wrote: > > [...] >> >> diff --git a/include/uapi/linux/netfilter_bridge/ebtables.h b/include/uapi/linux/netfilter_bridge/ebtables.h >> index a494cf43a755..e634da196d08 100644 >> --- a/include/uapi/linux/netfilter_bridge/ebtables.h >> +++ b/include/uapi/linux/netfilter_bridge/ebtables.h >> @@ -182,12 +182,14 @@ struct ebt_entry { >> unsigned char sourcemsk[ETH_ALEN]; >> unsigned char destmac[ETH_ALEN]; >> unsigned char destmsk[ETH_ALEN]; >> - /* sizeof ebt_entry + matches */ >> - unsigned int watchers_offset; >> - /* sizeof ebt_entry + matches + watchers */ >> - unsigned int target_offset; >> - /* sizeof ebt_entry + matches + watchers + target */ >> - unsigned int next_offset; >> + struct_group(offsets, >> + /* sizeof ebt_entry + matches */ > > This is an UAPI header, I think you need to use __struct_group here. Thanks for the reminder! I've fixed it in v2: https://lore.kernel.org/all/20230808133038.771316-1-gongruiqi@xxxxxxxxxxxxxxx/ Please review it :)