Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2022-10-27 at 13:31 -0700, Jakub Kicinski wrote:
> > On Mon, 5 Sep 2022 12:09:36 +0200 Florian Westphal wrote:
> > > struct {
> > > s16 min, max;
> > > + u8 network_byte_order:1;
> > > };
> >
> > This makes the union 64bit even on 32bit systems.
> > Do we care? Should we accept that and start using
> > full 64bits in other validation members?
> >
> > We can quite easily steal a bit elsewhere, which
> > I reckon may be the right thing to do, but I thought
> > I'd ask.
I'm fine with scraping the marker elsewhere.
> In fact we could easily just have three extra types NLA_BE16, NLA_BE32
> and NLA_BE64 types without even stealing a bit?
Sure, I can make a patch if there is consensus that new types are the
way to go.
