On 09/09/2022 12:48, Konstantin Meskhidze (A) wrote:
9/6/2022 11:07 AM, Mickaël Salaün пишет:
[...]
diff --git a/security/landlock/ruleset.h b/security/landlock/ruleset.h index 647d44284080..bb1408cc8dd2 100644 --- a/security/landlock/ruleset.h +++ b/security/landlock/ruleset.h @@ -49,6 +49,33 @@ struct landlock_layer { access_mask_t access; }; +/** + * union landlock_key - Key of a ruleset's red-black tree + */ +union landlock_key { + struct landlock_object *object; + uintptr_t data; +}; + +/** + * enum landlock_key_type - Type of &union landlock_key + */ +enum landlock_key_type { + /** + * @LANDLOCK_KEY_INODE: Type of &landlock_ruleset.root_inode's node + * keys. + */ + LANDLOCK_KEY_INODE = 1, +}; + +/** + * struct landlock_id - Unique rule identifier for a ruleset + */ +struct landlock_id { + union landlock_key key; + const enum landlock_key_type type; +};You can add these new types to Documentation/security/landlock.rst (with this commit). You need to complete all the new field descriptions though (otherwise you'll get Sphinx warnings): object, data, key, type.Sorry I did not get this tip. Can you explain more detailed here, about Sphinx warnings?
You need to add comments for all the fields as it is done for other structs. The Sphinx warnings come from make htmldocs.
