On 20.05.22 09:50, Pablo Neira Ayuso wrote:
I'm sssuming we relax the requirement as I proposed, ie. allow for not
allow devices to support for hardware offload, but at least one.
Then, it should be possible to extend the netlink interface to promote
a flowtable to support hardware offload, e.g.
add flowtable inet x y { hook ingress devices = { eth0, eth1 } priority 0; flags offload; }
For an existing flowtable, that will add eth0 and eth1, and it will
request to turn hardware offload.
This is not supported, these bits are missing in the netlink interface.
I still think the best course of action is to silently accept the offload
flag even if none of the devices support hw offload.
Silent means user is asking for something that is actually not
supported, there will be no effective way from the control plane to
check if what they request is actually being applied.
I'd propose two changes:
- relax the existing requirement, so if one device support hw offload,
then accept the configuration.
- allow to update a flowtable to on/off hardware offload from netlink
interface without needing to reload your whole ruleset.
I still don't see the value in forcing user space to do the
failure-and-retry dance if none of the devices support hw offload.
If this is about notifying user space about the hw offload status, I
think it's much better to simply accept such configurations as-is and
extend the netlink api to report which of the member devices hw offload
was actually enabled for.
This would be much more valuable to users that actually care about the
hw offload status than knowing if one of the devices in the list has hw
offload support, and it would simplify the code as well, for kernel and
user space alike.
- Felix
