Re: [libnfnetlink PATCH 1/2] include: Silence gcc warning in linux_list.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 25, 2022 at 06:34:25PM +0100, Phil Sutter wrote:
> Compiler complained about empty prefetch() macro:
> 
> | ../include/linux_list.h:385:66: warning: right-hand operand of comma expression has no effect [-Wunused-value]
> |   385 |         for (pos = list_entry((head)->next, typeof(*pos), member),      \
> |       |                                                                  ^
> 
> Use nftables' variant instead which gcc seems to like more.

LGTM, thanks

> Fixes: 36d2ed3de20a3 ("major cleanup of index2name infrastructure: use linux list (and fix leak in the nlif_close path)")
> Signed-off-by: Phil Sutter <phil@xxxxxx>



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux