Re: [libnfnetlink PATCH 2/2] libnfnetlink: Check getsockname() return code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [libnfnetlink PATCH 2/2] libnfnetlink: Check getsockname() return code
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Tue, 29 Mar 2022 23:28:00 +0200
Cc: netfilter-devel@xxxxxxxxxxxxxxx
In-reply-to: <20220325173426.11493-2-phil@nwl.cc>

On Fri, Mar 25, 2022 at 06:34:26PM +0100, Phil Sutter wrote:
> The function may return -1 (and set errno). Assume it will leave
> addr_len value unchanged, so checking is necessary to not hide the
> error.

LGTM.

> Fixes: 4248314d40187 ("nfnl: fix compilation warning with gcc-4.7")
> Signed-off-by: Phil Sutter <phil@xxxxxx>

References:
- [libnfnetlink PATCH 1/2] include: Silence gcc warning in linux_list.h
  - From: Phil Sutter
- [libnfnetlink PATCH 2/2] libnfnetlink: Check getsockname() return code
  - From: Phil Sutter

Prev by Date: Re: [libnetfilter_conntrack PATCH] expect/conntrack: Avoid spurious covscan overrun warning
Next by Date: Re: [libnfnetlink PATCH 1/2] include: Silence gcc warning in linux_list.h
Previous by thread: [libnfnetlink PATCH 2/2] libnfnetlink: Check getsockname() return code
Next by thread: Re: [libnfnetlink PATCH 1/2] include: Silence gcc warning in linux_list.h
Index(es):
- Date
- Thread

[Index of Archives] [Netfitler Users] [Berkeley Packet Filter] [LARTC] [Bugtraq] [Yosemite Forum]

Powered by Linux