On Thu, Mar 24, 2022 at 03:16:14PM +0100, Florian Westphal wrote: > Phil Sutter <phil@xxxxxx> wrote: > > With netdev and bridge nfprotos, loggers may see arbitrary ethernet > > frames. Print at least basic info like interfaces and MAC header data. > > Makes sense to me. > > > + /* FIXME: Disabled from containers until syslog ns is supported */ > > + if (!net_eq(net, &init_net) && !sysctl_nf_log_all_netns) > > + return; > > Hmm, this is now the 3rd incarnation of this comment + check, > perhaps create another patch that adds a helper? Yes, I thought about that already but found it not worth it. OTOH, copying outdated comments is a sin so I'll submit a follow-up. Thanks, Phil
