Re: [nf-next PATCH 2/2] netfilter: nf_log_syslog: Don't ignore unknown protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> With netdev and bridge nfprotos, loggers may see arbitrary ethernet
> frames. Print at least basic info like interfaces and MAC header data.

Makes sense to me.

> +	/* FIXME: Disabled from containers until syslog ns is supported */
> +	if (!net_eq(net, &init_net) && !sysctl_nf_log_all_netns)
> +		return;

Hmm, this is now the 3rd incarnation of this comment + check,
perhaps create another patch that adds a helper?

E.g.

if (!nf_log_allowed(net))
	return;

or similar.  Or just remove the FIXME line?  (Its not really a netfilter
todo/FIXME).



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux