On Thu, Mar 10, 2022 at 01:17:48PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@xxxxxx> wrote:
> > +static void notargets_hlist_insert(const char *name)
> > +{
> > + struct notarget *cur;
> > +
> > + if (!name)
> > + return;
> > +
> > + cur = xtables_malloc(sizeof(*cur) + strlen(name) + 1);
> > + cur->name[0] = '\0';
> > + strcat(cur->name, name);
>
> strcpy seems more readable than strcat here.
Oh, indeed. Looks like an old attempt at avoiding strncpy() compiler
warnings. ;)
Thanks, Phil
