On Wed, Dec 15, 2021 at 11:41:48PM +0100, Pablo Neira Ayuso wrote: > On Mon, Dec 13, 2021 at 07:07:45PM +0100, Phil Sutter wrote: > > This is supposed to hold the variant name (either "legacy" or > > "nf_tables") for use in shared help/error printing functions. > > Only one more nitpick: Probably you can store this in program_version? > It is also string then this skips the binary layout update of > xtables_globals. > > .program_version = PACKAGE_VERSION VARIANT, > > where VARIANT is " legacy" or " nf_tables". Works fine, thanks for the hint! > Apart from this, this batch LGTM, thanks. I'll incorporate the change, resubmit and push if nobody complains in a few hours. Thanks, Phil
