Re: [iptables PATCH v2 4/6] xtables_globals: Introduce program_variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 13, 2021 at 07:07:45PM +0100, Phil Sutter wrote:
> This is supposed to hold the variant name (either "legacy" or
> "nf_tables") for use in shared help/error printing functions.

Only one more nitpick: Probably you can store this in program_version?
It is also string then this skips the binary layout update of
xtables_globals.

.program_version = PACKAGE_VERSION VARIANT,

where VARIANT is " legacy" or " nf_tables".

Apart from this, this batch LGTM, thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux