On Mon, Oct 18, 2021 at 11:45:50AM +1100, Duncan Roe wrote: > On Sun, Oct 17, 2021 at 03:41:46PM +0200, Pablo Neira Ayuso wrote: > > On Sun, Oct 17, 2021 at 12:56:07PM +1100, Duncan Roe wrote: > > > Hi Pablo, > > > > > > On Sat, Oct 16, 2021 at 06:27:56PM +1100, Duncan Roe wrote: > > > > On Sat, Oct 16, 2021 at 03:39:48PM +1100, Duncan Roe wrote: > > > > > - configure --help lists non-default documentation options. > > > > > Looking around the web, this seemed to me to be what most projects do. > > > > > Listed options are --enable-html-doc & --disable-man-pages. > > > > > - --with-doxygen is removed: --disable-man-pages also disables doxygen unless > > > > > --enable-html-doc is asserted. > > > > > If html is requested, `make install` installs it in htmldir. > > > > > > > > > > Signed-off-by: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> > > > > > --- > > > > > v2: broken out from 0001-build-doc-Fix-man-pages.patch > > > > > v3: no change (still part of a series) > > > > > v4: remove --without-doxygen since -disable-man-pages does that > > > > > v5: - update .gitignore for clean `git status` after in-tree build > > > > > - in configure.ac: > > > > > - ensure all variables are always set (avoid leakage from environment) > > > > > - provide helpful warning if HTML enabled but dot not found > > > > [...] > > > > Sorry Pablo, this is for libnetfilter_queue. > > > > I don't see it in patchwork - did you get rid of it already? > > > > Will re-send with correct Sj. > > > > > > > Sorry again for the confusion but you dropped the good libnetfilter_log patch > > > that was Tested-by: Jeremy Sowden and left the bad libnetfilter_log patch that > > > actually applies to libnetfilter_queue. > > > > Are you refering to this patch? > > > > https://patchwork.ozlabs.org/project/netfilter-devel/patch/20211017013951.12584-1-duncan_roe@xxxxxxxxxxxxxxx/ > > > > This is the one that Jeremy added the Tested-by: tag, correct? > > Yes that's the one. I re-sent it To be unambiguous, the bad patch is https://patchwork.ozlabs.org/project/netfilter-devel/patch/20211016043948.2422-1-duncan_roe@xxxxxxxxxxxxxxx/ If you would remove that, then patchwork will be all good. Cheers ... Duncan.
