Hey, On Tue, Sep 14, 2021 at 11:03:42AM +0200, Štěpán Němec wrote: > On Mon, 13 Sep 2021 17:05:33 +0200 > Phil Sutter wrote: > > > Applied, thanks! > > Thank you. > > I see that you've pushed your series including the change to print error > messages to stdout [1] in the meantime. > > I don't have a strong opinion on whether output of a script whose > (only?) purpose is to print diagnostic messages should go to stdout or > stderr, but I do think that having the "ERROR"s go to stderr and "OK"s > go to stdout is more confusing than useful: was that really intentional? > > As a side effect of that change, my patch will act funny depending on > which output stream is being redirected, too. Argh, you're right and I missed that. Printing errors to stderr is useful to compare failing tests against an expected set of failures - it is simply a task of comparing output on stderr with a recorded one. To not overcomplicate things, maybe the easiest fix would be to print colors only if both stdout and stderr are a tty. What do you think? Cheers, Phil
