Re: [PATCH iptables] print with color escapes only when stdout isatty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, 13 Sep 2021 17:05:33 +0200
Phil Sutter wrote:

> Applied, thanks!

Thank you.

I see that you've pushed your series including the change to print error
messages to stdout [1] in the meantime.

I don't have a strong opinion on whether output of a script whose
(only?) purpose is to print diagnostic messages should go to stdout or
stderr, but I do think that having the "ERROR"s go to stderr and "OK"s
go to stdout is more confusing than useful: was that really intentional?

As a side effect of that change, my patch will act funny depending on
which output stream is being redirected, too.

(I'm sorry I haven't pointed this out earlier; I just skimmed your
patches and didn't notice this until double checking the conflict/merge
with my patch now.)



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux