On 26.05.2021 17:06, Nicolas Dichtel wrote: > Le 26/05/2021 à 16:34, Ali Abdallah a écrit : > > That what the doc on nf_conntrack_tcp_be_liberal says as well, logically > > not 0 is 1, so IMHO I don't think that can lead to confusion. > > There is a lot of sysctl that have several magic values, see > https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt > > And some act like boolean but accept all values, > /proc/sys/net/ipv4/conf/*/forwarding for example. > > There is nothing obvious with sysctl values (and a lot of inconsistencies), it's > why I suggest to be explicit. Yes, I absolutely see your point, and I have no problem in making that explicit, I will sent a v2 patch saying explicitly that only "1" would disable RST seq number checks, hopefully it gets merged soon. > Regards, > Nicolas Kind Regards, Ali
