Le 26/05/2021 à 16:34, Ali Abdallah a écrit : > On 26.05.2021 16:29, Nicolas Dichtel wrote: >>> +nf_conntrack_tcp_ignore_invalid_rst - BOOLEAN >>> + - 0 - disabled (default) >>> + - not 0 - enabled >> If I correctly read the patch, the only "not 0" possible value is 1. Why not >> using explicitly "1"? > > That what the doc on nf_conntrack_tcp_be_liberal says as well, logically > not 0 is 1, so IMHO I don't think that can lead to confusion. There is a lot of sysctl that have several magic values, see https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt And some act like boolean but accept all values, /proc/sys/net/ipv4/conf/*/forwarding for example. There is nothing obvious with sysctl values (and a lot of inconsistencies), it's why I suggest to be explicit. Regards, Nicolas
