Hi Jan,
On Thu, Apr 29, 2021 at 05:11:49PM +0200, Jan Engelhardt wrote:
[...]
> >+struct xt_secmark_tginfo {
> >+ __u8 mode;
> >+ char secctx[SECMARK_SECCTX_MAX];
> >+ __u32 secid;
> >+};
>
> that should be struct xt_secmark_tginfo_v1.
The v0 struct is called xt_secmark_target_info, I guess Pablo tried to
shorten the name a bit. In conforming to "the standard", I'd then go
with xt_secmark_target_info_v1 instead. Fine with you?
> >+ .name = "SECMARK",
> >+ .revision = 1,
> >+ .family = NFPROTO_UNSPEC,
> >+ .checkentry = secmark_tg_check_v2,
>
> Can't have revision=1 and then call it _v2. That's just confusing.
ACK, I missed that.
Thanks, Phil
