On Thursday 2021-04-29 15:39, Phil Sutter wrote:
>
>This extension breaks when trying to delete rules, add a new revision to
>fix this.
>
>diff --git a/include/uapi/linux/netfilter/xt_SECMARK.h b/include/uapi/linux/netfilter/xt_SECMARK.h
>index 1f2a708413f5d..f412c87e675c1 100644
>--- a/include/uapi/linux/netfilter/xt_SECMARK.h
>+++ b/include/uapi/linux/netfilter/xt_SECMARK.h
>@@ -20,4 +20,10 @@ struct xt_secmark_target_info {
> char secctx[SECMARK_SECCTX_MAX];
> };
>
>+struct xt_secmark_tginfo {
>+ __u8 mode;
>+ char secctx[SECMARK_SECCTX_MAX];
>+ __u32 secid;
>+};
that should be struct xt_secmark_tginfo_v1.
>+ .name = "SECMARK",
>+ .revision = 1,
>+ .family = NFPROTO_UNSPEC,
>+ .checkentry = secmark_tg_check_v2,
Can't have revision=1 and then call it _v2. That's just confusing.
