On Mon, 15 Jun 2020 15:21:34 +0200 Phil Sutter <phil@xxxxxx> wrote: > On Mon, Jun 15, 2020 at 02:40:55PM +0200, Stefano Brivio wrote: > > > > [...] > > > > Commit 7d93e2c2fbc7 (which makes it "configurable") is from March 2018. > > I think you're misinterpreting that commit regarding an attempt at > making diff binary configurable. > > [...] > > > [...] > > > > # grep DIFF=\" nftables/tests/shell/run-tests.sh > > DIFF="diff -y" > > This is no guaranteed functionality. There's no comment or anything > stating you could change the DIFF definition atop the script to > customize diff behaviour. But... # Configuration TESTDIR="./$(dirname $0)/" RETURNCODE_SEPARATOR="_" SRC_NFT="$(dirname $0)/../../src/nft" +POSITIVE_RET=0 +DIFF=$(which diff) :) well, now that you tell me, I can guess that "# Configuration" only applied to the original parts, and the rest was added there simply because there were no other "sections". > [...] > > As said, the quotes are there to cover the expected 'which' output, no > more and no less. Supporting user-defined diff-command (or custom > options) is new functionality IMO. I'm totally fine with that and merely > want to point out we're not talking about fixing a bug here. Okay, I see. I'll try to get back to that soon. Pablo, I think you can drop this patch. -- Stefano
