On Sun, May 10, 2020 at 05:10:01PM +0200, Pablo Neira Ayuso wrote: > On Sun, May 10, 2020 at 11:53:17PM +1000, Duncan Roe wrote: > > pktb_alloc2() avoids the malloc/free overhead in pktb_alloc() and also > > eliminates memcpy() of the payload except when mangling increases the > > packet length. > > > > - pktb_mangle() does the memcpy() if need be. > > Packet metadata is altered in this case > > - All the _mangle functions are altered to account for possible change tp > > packet metadata > > - Documentation is updated > > Many chunks of this patchset look very much the same I posted. I'll > apply my patchset and please rebase any update on top of it. Your patchset is crap. No documentation, giant holes that I haven't had time to reply to... Apply this junk and I am walking away from netfilter. > > Thanks. -Duncan