On Mon, Apr 20, 2020 at 01:28:22PM +0100, Edward Cree wrote: > On 20/04/2020 12:52, Jiri Pirko wrote: > > However for TC, when user specifies "HW_STATS_DISABLED", the driver > > should not do stats. > > What should a driver do if the user specifies DISABLED, but the stats > are still needed for internal bookkeeping (e.g. to prod an ARP entry > that's in use for encapsulation offload, so that it doesn't get > expired out of the cache)? Enable the stats on the HW anyway but > not report them to FLOW_CLS_STATS? Or return an error? My interpretation is that HW_STATS_DISABLED means that the front-end does not care / does not need counters. The driver can still allocate them if needed. So the enum flow_action_hw_stats flags represent what the front-end requires.
