Mon, Apr 20, 2020 at 02:28:22PM CEST, ecree@xxxxxxxxxxxxxx wrote: >On 20/04/2020 12:52, Jiri Pirko wrote: >> However for TC, when user specifies "HW_STATS_DISABLED", the driver >> should not do stats. >What should a driver do if the user specifies DISABLED, but the stats > are still needed for internal bookkeeping (e.g. to prod an ARP entry > that's in use for encapsulation offload, so that it doesn't get > expired out of the cache)? Enable the stats on the HW anyway but > not report them to FLOW_CLS_STATS? Or return an error? If internally needed, it means they cannot be disabled. So returning error would make sense, as what the user requested is not supported. > >-ed
