Hi, On Mon, 17 Feb 2020 10:53:59 +0100 Florian Westphal <fw@xxxxxxxxx> wrote: > -struct nft_set_type nft_set_pipapo_type __read_mostly = { > - .owner = THIS_MODULE, > +const struct nft_set_type nft_set_pipapo_type __read_mostly = { const ... read_mostly should make no sense because const already forces the data to a read-only segment. It might actually cause some issues, see https://lore.kernel.org/patchwork/patch/439824/. It's not there for the other set types, so I'm assuming it's a typo :) -- Stefano