On Mon, Nov 25, 2019 at 10:52:40AM +1100, Duncan Roe wrote: > Hi Floerian, > > On Sun, Nov 24, 2019 at 03:45:47PM +0100, Florian Westphal wrote: > > Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> wrote: > > > This makes it clear which lines are no longer required. > > > It also obviates the need to document NFQNL_CFG_CMD_PF_(UN)BIND. > > > > Why not simply #if 0 this code? > > Simple reason: I think it's important to have an indicator on each commented-out > line that it is,in fact, commented-out. > > > > Or just delete it, v3.8 was released almost 7 years ago. > > I could do that. But, I'm uneasy about it. There are systems around with very > old Linuxes - in May last year there was that Tomato Firmware non-issue and the > embedded environment was at 2.6! > > Your call (or Pablo's) - I'm happy either way. I think it's fine to remove it. There will be a commit message describing this is only required by very old kernel, which should be good enough for people with exotic environments to catch up I would expect. Thanks.
