Hi Floerian, On Sun, Nov 24, 2019 at 03:45:47PM +0100, Florian Westphal wrote: > Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> wrote: > > This makes it clear which lines are no longer required. > > It also obviates the need to document NFQNL_CFG_CMD_PF_(UN)BIND. > > Why not simply #if 0 this code? Simple reason: I think it's important to have an indicator on each commented-out line that it is,in fact, commented-out. > > Or just delete it, v3.8 was released almost 7 years ago. I could do that. But, I'm uneasy about it. There are systems around with very old Linuxes - in May last year there was that Tomato Firmware non-issue and the embedded environment was at 2.6! Your call (or Pablo's) - I'm happy either way. Cheers ... Duncan. On Sun, 27 May 2018 01:02:46 -0400, Edriss Mirzadeh wrote: > Hi there, > > I???m actually cross compiling Tomato Firmware using 64 bit Debian 9. > > The build instructions are good at the below URL, except for the repo name > which recently changed but hasn???t yet been updated in the readme > instructions. > > https://bitbucket.org/kille72/freshtomato-arm/src > > This could well be due to either the cross-compilation or the very old tool > chain, or ancient kernel 2.6 (with many back ports), but I do agree that > local headers should be double quoted, so your thought on patch rings true > in terms of portability. > > Cheers!
