On Mon, Oct 28, 2019 at 03:17:05PM +0100, Pablo Neira Ayuso wrote: > On Mon, Oct 28, 2019 at 03:04:21PM +0100, Phil Sutter wrote: > > A review of xtables-arp.c exposed a significant amount of dead, needless > > or duplicated code. This series deals with some low hanging fruits. Most > > of the changes affect xtables-arp.c and nft-arp.c only, but where common > > issues existed or code was to be shared, other files are touched as > > well. > > Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> I'll have to respin, patch 7 breaks arptables-nft for inverted options - I missed how the actual values are used in inverse_for_options variable and ran 'iptables-test.py -n' just now. Sorry for the noise! Cheers, Phil
