A review of xtables-arp.c exposed a significant amount of dead, needless or duplicated code. This series deals with some low hanging fruits. Most of the changes affect xtables-arp.c and nft-arp.c only, but where common issues existed or code was to be shared, other files are touched as well. Phil Sutter (10): ip6tables, xtables-arp: Drop unused struct pprot xshared: Share a common add_command() implementation xshared: Share a common implementation of parse_rulenumber() Merge CMD_* defines xtables-arp: Drop generic_opt_check() Replace TRUE/FALSE with true/false xtables-arp: Integrate OPT_* defines into xshared.h xtables-arp: Drop some unused variables xtables-arp: Use xtables_parse_interface() nft-arp: Use xtables_print_mac_and_mask() iptables/ip6tables.c | 73 +------------ iptables/iptables.c | 64 +---------- iptables/nft-arp.c | 31 +----- iptables/nft-shared.h | 17 --- iptables/xshared.c | 39 +++++++ iptables/xshared.h | 32 ++++++ iptables/xtables-arp.c | 237 +++-------------------------------------- iptables/xtables.c | 48 +-------- 8 files changed, 97 insertions(+), 444 deletions(-) -- 2.23.0
