Re: [PATCH nftables 1/3] src, include: add upstream linenoise source.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-09-22, at 10:22:37 +0100, Jeremy Sowden wrote:
> On 2019-09-22, at 09:09:24 +0200, Pablo Neira Ayuso wrote:
> > On Sat, Sep 21, 2019 at 09:19:23PM +0200, Jan Engelhardt wrote:
> > > On Saturday 2019-09-21 14:20, Jeremy Sowden wrote:
> > >
> > > >  https://github.com/antirez/linenoise/
> > > >
> > > >The upstream repo doesn't contain the infrastructure for building
> > > >or installing libraries.  There was a 1.0 release made in 2015,
> > > >but there have been a number of bug-fixes committed since.
> > > >Therefore, add the latest upstream source:
> > >
> > > > src/linenoise.c     | 1201 +++++++++++++++++++++++++++++++++++++++++++
> > >
> > > That seems like a recipe to end up with stale code. For a
> > > distribution, it's static linking worsened by another degree.
> > >
> > > (https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries)
> >
> > I thought this is like mini-gmp.c?
>
> That was also my impression.

The other thing I forgot to reiterate this morning is that linenoise
support was requested for embedded environments where readline is not an
option.  I don't expect it to be used in general-purpose distro's which
_do_ have readline available.

J.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux