Re: [PATCH nftables 1/3] src, include: add upstream linenoise source.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-09-22, at 09:09:24 +0200, Pablo Neira Ayuso wrote:
> On Sat, Sep 21, 2019 at 09:19:23PM +0200, Jan Engelhardt wrote:
> >
> > On Saturday 2019-09-21 14:20, Jeremy Sowden wrote:
> >
> > >  https://github.com/antirez/linenoise/
> > >
> > >The upstream repo doesn't contain the infrastructure for building or
> > >installing libraries.  There was a 1.0 release made in 2015, but there
> > >have been a number of bug-fixes committed since.  Therefore, add the
> > >latest upstream source:
> >
> > > src/linenoise.c     | 1201 +++++++++++++++++++++++++++++++++++++++++++
> >
> > That seems like a recipe to end up with stale code. For a distribution,
> > it's static linking worsened by another degree.
> >
> > (https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries)
>
> I thought this is like mini-gmp.c?

That was also my impression.

> Are distributors packaging this as a library?

It turns out that Fedora has packaged an old fork of it, which is also
available in EPEL, and I missed it.  Apologies.  There's nothing in
Debian or Ubuntu.

How about adding an `AC_CHECK_LIB([linenoise], ...)` check and falling
back to the bundled copy?

J.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux