Re: [PATCH nf-next] netfilter: connlabels: prefer static lock initialiser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 12, 2019 at 01:40:04PM +0200, Florian Westphal wrote:
> seen during boot:
> BUG: spinlock bad magic on CPU#2, swapper/0/1
>  lock: nf_connlabels_lock+0x0/0x60, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
> Call Trace:
>  do_raw_spin_lock+0x14e/0x1b0
>  nf_connlabels_get+0x15/0x40
>  ct_init_net+0xc4/0x270
>  ops_init+0x56/0x1c0
>  register_pernet_operations+0x1c8/0x350
>  register_pernet_subsys+0x1f/0x40
>  tcf_register_action+0x7c/0x1a0
>  do_one_initcall+0x13d/0x2d9
> 
> Problem is that ct action init function can run before
> connlabels_init().  Lock has not been initialised yet.
> 
> Fix it by using a static initialiser.

Applied, thanks Florian.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux