Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Mon, 22 Apr 2019 10:38:13 +0200
Cc: Florian Westphal <fw@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
In-reply-to: <20190417164944.1462-1-avagin@gmail.com>
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, Apr 17, 2019 at 09:49:44AM -0700, Andrei Vagin wrote:
> It doesn't log a packet if sysctl_log_invalid isn't equal to protonum
> OR sysctl_log_invalid isn't equal to IPPROTO_RAW. This sentence is
> always true. I believe we need to replace OR to AND.

Applied, thanks.

Follow-Ups:
- Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets
  - From: Dexuan-Linux Cui

References:
- [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets
  - From: Andrei Vagin

Prev by Date: Re: [PATCH nf] netfilter: never get/set skb->tstamp
Next by Date: Re: [PATCH] netfilter: fix dangling pointer access of fake_rtable
Previous by thread: Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets
Next by thread: Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets
Index(es):
- Date
- Thread

[Index of Archives] [Netfitler Users] [Berkeley Packet Filter] [LARTC] [Bugtraq] [Yosemite Forum]

Powered by Linux