Re: [PATCH nf] netfilter: never get/set skb->tstamp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 17, 2019 at 02:17:23AM +0200, Florian Westphal wrote:
> setting net.netfilter.nf_conntrack_timestamp=1 breaks xmit with fq
> scheduler.  skb->tstamp might be "refreshed" using ktime_get_real(),
> but fq expects CLOCK_MONOTONIC.
> 
> This patch removes all places in netfilter that check/set skb->tstamp:
> 
> 1. To fix the bogus "start" time seen with conntrack timestamping for
>    outgoing packets, never use skb->tstamp and always use current time.
> 2. In nfqueue and nflog, only use skb->tstamp for incoming packets,
>    as determined by current hook (prerouting, input, forward).
> 3. xt_time has to use system clock as well rather than skb->tstamp.
>    We could still use skb->tstamp for prerouting/input/foward, but
>    I see no advantage to make this conditional.

Applied, thanks Florian.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux