Re: [PATCH nf] netfilter: nf_tables: add missing ->release_ops() in error path of newrule()

[Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>]

On Tue, Mar 19, 2019 at 01:22:41PM +0900, Taehee Yoo wrote:
> ->release_ops() callback releases resources and this is used in error path.
> If nf_tables_newrule() fails after ->select_ops(), it should release
> resources. but it can not call ->destroy() because that should be called
> after ->init().
> At this point, ->release_ops() should be used for releasing resources.
> 
> Test commands:
>    modprobe -rv xt_tcpudp
>    iptables-nft -I INPUT -m tcp   <-- error command
>    lsmod
> 
> Result:
>    Module                  Size  Used by
>    xt_tcpudp              20480  2      <-- it should be 0

Applied, thanks!