Re: [conntrack-tools PATCH] Fix for implicit-fallthrough warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 13, 2019 at 06:39:16PM +0100, Phil Sutter wrote:
> On Wed, Feb 13, 2019 at 06:21:00PM +0100, Pablo Neira Ayuso wrote:
> > On Wed, Feb 13, 2019 at 12:13:44AM +0100, Phil Sutter wrote:
> > > Mark fall through cases as such. Note that correctness of those fall
> > > throughs have not been verified.
> > 
> > Applied, thanks.
> > 
> > BTW, do we need to update any Makefile to include a new -W option for
> > gcc to check for missing "fall through"?
> 
> TBH, I have no idea. :)
> 
> I use gcc-8.2.0 here and it emitted the warnings by default. Maybe with
> older versions you need -Wimplicit-fallthrough to see them?

No problem, just asking. I think it's fine, no need to update
Makefile.am

Thanks!



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux