Re: [PATCH nf-next v10] netfilter: nft_ct: add ct timeout support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Harsha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Harsha-Sharma/netfilter-nft_ct-add-ct-timeout-support/20180802-001147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   net//netfilter/nft_ct.c: In function 'nft_ct_timeout_obj_destroy':
>> net//netfilter/nft_ct.c:899:3: error: implicit declaration of function 'nf_ct_untimeout'; did you mean 'nf_ct_netns_put'? [-Werror=implicit-function-declaration]
      nf_ct_untimeout(ctx->net, priv->timeout);
      ^~~~~~~~~~~~~~~
      nf_ct_netns_put
   cc1: some warnings being treated as errors

vim +899 net//netfilter/nft_ct.c

   888	
   889	static void nft_ct_timeout_obj_destroy(const struct nft_ctx *ctx,
   890					       struct nft_object *obj)
   891	{
   892		struct nft_ct_timeout_obj *priv = nft_obj_data(obj);
   893	
   894		nf_ct_tmpl_free(priv->tmpl);
   895	
   896		if (refcount_dec_if_one(&priv->timeout->refcnt)) {
   897			nf_ct_l4proto_put(priv->timeout->l4proto);
   898			list_del_rcu(&priv->timeout->head);
 > 899			nf_ct_untimeout(ctx->net, priv->timeout);
   900		}
   901	}
   902	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux