On Fri, Jul 27, 2018 at 12:45:13PM +0200, Phil Sutter wrote:
> Hi,
>
> On Fri, Jul 27, 2018 at 11:43:20AM +0200, Pablo Neira Ayuso wrote:
> > On Fri, Jul 27, 2018 at 12:22:30AM +0200, Phil Sutter wrote:
> > > It is perfectly legal to specify an empty argument using two double
> > > quotes, e.g. '--log-prefix ""'. Fix the parser in add_param_to_argv() to
> > > detect this situation and not treat it like double spaces.
> >
> > Not sure about this one, because add_param_to_argv() should be the
> > original function we have in iptables-restore, and now it is
> > diverting. Are you sure about this?
> >
> > If this is fixed here, probably we should consider it fixing it up in
> > legacy at this stage.
>
> Oh, I wasn't aware there are two copies of those functions. I'll merge
> them into xshared.{c,h} as a follow-up, if that's OK?
I think so. Have a look.
That can be done in a follow up patch. No need to resend patchset.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
