Florian's request to add testcases for the added save and restore implementations really stroke home, thanks for that! As (probably) expected, this series not only contains the requested testcases, but also a huge pile of fixes. Some of them fix memleaks identified using valgrind. Phil Sutter (23): xtables: Fix symlinks/names for ebtables-{save,restore} xtables: Fix memleak when adding builtin chains xtables: Use correct built-in chain count xtables: Fix debug output ebtables: Fix match_list insertion xtables: Fix ebtables-restore ebtables: Fix memleak in do_commandeb() arptables: Print policy only for base chains ebtables: Support --init-table command xtables: Implement arptables-{save,restore} xtables: Fix for empty quotes in add_params_to_argv() ebtables: Print non-standard target parameters ebtables: Fix loading of non-standard targets ebtables: Fix segfault when parsing a rule arptables: Fix printing non-standard target parameters arptables: Fix memleak in do_commandarp() arptables: Fix memleaks in target handling arptables: Fix jumps into user-defined chains arptables: Fix for trailing spaces in output arptables: Fix opcode printing in numeric output xtables: Always set FMT_NUMERIC when saving rules tests: Add arptables-{save,restore} testcase tests: Add ebtables-{save,restore} testcase extensions/libarpt_mangle.c | 40 ++--- iptables/Makefile.am | 5 +- iptables/nft-arp.c | 52 ++++--- iptables/nft-bridge.c | 24 ++- iptables/nft.c | 7 +- iptables/nft.h | 1 + .../arptables/0001-arptables-save-restore_0 | 57 +++++++ .../ebtables/0002-ebtables-save-restore_0 | 109 +++++++++++++ iptables/xtables-arp-standalone.c | 17 +- iptables/xtables-arp.c | 65 +++++--- iptables/xtables-eb.c | 48 +++--- iptables/xtables-multi.h | 2 + iptables/xtables-nft-multi.c | 8 +- iptables/xtables-restore.c | 146 ++++++++++++++++-- iptables/xtables-save.c | 47 +++++- 15 files changed, 495 insertions(+), 133 deletions(-) create mode 100755 iptables/tests/shell/testcases/arptables/0001-arptables-save-restore_0 create mode 100755 iptables/tests/shell/testcases/ebtables/0002-ebtables-save-restore_0 -- 2.18.0 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html