Shaochun Chen <cscnull@xxxxxxxxx> wrote: [ CC Tom Herbert ] > and the memory which pointed by control->data will leak. so if netlink_dump > start fail, call control->done to free the memory. Tom, I was about to suggest moving extra allocations for dumps into a ->start() callback whereever possible. However, it looks like ->done() is not guaranteed to be called even if ->start() was invoked, but it seems at least ila assumes ->done always cleans up after ->start. I am looking at netlink_dump(); it calls ->done() only after the dump callback was invoked. In nf_tables_api.c case it might be possible to defer allocations until ->dump() is called for first time via cb_args but I don't think its going to be any better than cleaning up manually after netlink_dump_start() returned an error. Any better ideas or advice on how to procceed? Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
