Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > On Sun, Jul 22, 2018 at 4:51 AM Shaochun Chen <cscnull@xxxxxxxxx> wrote: > But even if you moved it somehow to the if(ret), I'm still not sure > it'd be correct; start cbs should either succeed, or they should error > out and cleanup entirely after themselves. I agree, ->done() should not be called if cb->dump() was never invoked. All ctnetlink and nf_tables spots need to cleanup after themselves. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
