Re: [PATCH nf 1/4] netfilter: nft_set_hash: fix panic when destroying set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-07-02 20:45 GMT+09:00 Florian Westphal <fw@xxxxxxxxx>:
> Taehee Yoo <ap420073@xxxxxxxxx> wrote:
>> In order to destroy elements of set, a rhashtable_free_and_destroy()
>> is used. the rhashtable_free_and_destroy() cancels a re-hash deferred work
>> then walks and destroys elements. at this moment, some elements are
>> still in a future_tbl. that elements are not destroyed.
>
> Wait.  Isn't that a bug in rhashtable_free_and_destroy()?
>
> I'd rather see rhashtable_free_and_destroy() do it correctly if
> possible rather than asking users of rhashtable_free_and_destroy()
> to not use that function...
>

Thank you for reviewing!

I didn't doubt that rhashtable_free_and_destroy has bug.
But on second thought, you're right. it seems that it's a bug in
rhashtable_free_and_destroy()

> Or did i misunderstand and its a nft specific problem?

You understood it correctly and
In my opinion, it's an ordinary case.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux