Re: [PATCH 2/6] build: rename sed source files to .in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt <jengelh@xxxxxxx> wrote:
> On Friday 2018-06-29 12:11, Pablo Neira Ayuso wrote:
> 
> >On Fri, Jun 29, 2018 at 12:05:12PM +0200, Jan Engelhardt wrote:
> >> So does that mean we're not going to address the build failure
> >> experienced by Duncan Roe and the tomato project?
> >
> >I think we agreed the problem there is a very old toolchain that is
> >ignoring -I for some reason, right?
> 
> Negative! It *is* a bug in the ebtables makefilery, quoting myself
> from earlier:
> 
> """ freshtomato must not override KERNEL_INCLUDES. Yes, ebtables's
> Makefile invites one *to do so*. ebtables's Makefile is wrong to
> suggest so. """

AH, well, yes.  I forgot about that.

There is a patch from Duncan to address this based on your earlier
patch I think.

Is that understanding correct?

> >IIRC, your patchset is targeting to something else. I think there must
> >be a more minimalistic way to fix that.
> 
> Well yeah there is, I tried it, and then thought,
> gee, I am a German, I should be solving the issue thoroughly
> rather than just bandaiding an old Makefile.

:-)

Ok, I see, your series supersedes that 'bandaid patch'.
Let me re-consider applying this.

My only concern is someone complaining/asking where the ebt_foo.so files
went.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux