On Fri, Jun 29, 2018 at 10:14:04AM +0200, Jan Engelhardt wrote: > On Thursday 2018-06-28 22:43, Florian Westphal wrote: > > >Jan Engelhardt <jengelh@xxxxxxx> wrote: > >> Prepare for autoconf-based substitution of macros in the file. > > > >It breaks make install. > > > >Not a big deal, after pulling wholse series make seems to create > >a static build by default, make install DESTDIR=/tmp/foo results > >in all the ebt_foo.so files being omitted, instead they're part of > >libebt.so. Is that intentional? > > > >Whats the rationale? > > I would assume that the reason they were all separate .so files > before is because "_init" can only appear once per .so file > and the original author did not know about ((constructor)) back then. > > One can have multiple __attribute__((constructor)) per executable, > and since all of ebtables is always loaded into memory, there was no > more reason to spread the code into many many .so files (disk seeks). Not sure this is worth this change. I would prefer conversion to autotools is just as transparent as possible. Having said this, as Florian mentioned already, modernizing and ebtables are two things that are not really worth. Most likely better to place the limited (wo)manpower we have to other ongoing upstream developments, but this is just a suggestion, of course. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
