On Tue, May 15, 2018 at 12:42:09AM +0200, Florian Westphal wrote:
> Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> wrote:
> > Since commit b1cdae87f25021eb835872d86d6e7206bd421c3f, make fails thusly:
> >
> > > libebtc.c: In function 'ebt_reinit_extensions':
> > > libebtc.c:275:11: error: 'union <anonymous>' has no member named 'revision'
> > > m->m->u.revision = m->revision;
> > > ^
> > > libebtc.c: In function 'ebt_check_rule_exists':
> > > libebtc.c:555:21: error: 'union <anonymous>' has no member named 'revision'
> > > m_l2->m->u.revision != m->m->u.revision)) {
> > > ^
> > > libebtc.c:555:41: error: 'union <anonymous>' has no member named 'revision'
> > > m_l2->m->u.revision != m->m->u.revision)) {
> > > ^
> > > libebtc.c: In function 'ebt_register_match':
> > > libebtc.c:1215:9: error: 'union <anonymous>' has no member named 'revision'
> > > m->m->u.revision = m->revision;
> > > ^
> > The cause of this failure is that the commit updated include/ebtables.h but
> > libebtc.c uses include/linux/netfilter_bridge/ebtables.h via
> > include/ebtables_u.h (gcc -E -C verifies this).
> >
> > The 2 versions of ebtables.h looked to me to be otherwise close enough, so
> > amended ebtables_u.h to use the newer one.
> >
> > Makefile insists on being warning-free, so cleared up warnings. Apart from
> > unused variables, there was also the issue that the diagnostic macro
> > ebt_print_error2 *returns* (i.e. makes its caller return) and returns -1. This
> > is unsuitable for use in functions which do not return a value, so introduced
> > ebt_print_error3 to do this.
>
> Applied, thanks Duncan.
> I made one change, build still failed for me on FC28 due to strncpy
> warning:
>
> extensions/ebt_string.c:171:3: error: ???strncpy??? specified bound 16
> equals destination size [-Werror=stringop-truncation]
> strncpy(info->algo, optarg, XT_STRING_MAX_ALGO_NAME_SIZE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Odd that. I didn't see this line being changed, but am not getting a warning
from gcc8.1 (that FC28 has, right?).
Cheers ... Duncan.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
