Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-add-struct-nf_ct_hook-and-use-it/20180515-034151 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All warnings (new ones prefixed by >>): In file included from include/linux/netfilter_ingress.h:5:0, from net//core/dev.c:144: >> include/linux/netfilter.h:363:14: warning: 'enum ip_conntrack_info' declared inside parameter list will not be visible outside of this definition or declaration enum ip_conntrack_info ctinfo); ^~~~~~~~~~~~~~~~~ vim +363 include/linux/netfilter.h 360 361 struct nf_ct_hook { 362 int (*update)(struct net *net, struct sk_buff *skb, struct nf_conn *ct, > 363 enum ip_conntrack_info ctinfo); 364 void (*destroy)(struct nf_conntrack *); 365 }; 366 extern struct nf_ct_hook __rcu *nf_ct_hook; 367 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip