Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-add-struct-nf_ct_hook-and-use-it/20180515-034151 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) net/netfilter/nf_nat_core.c:599:25: sparse: incompatible types in comparison expression (different address spaces) net/netfilter/nf_nat_core.c:837:9: sparse: incompatible types in comparison expression (different address spaces) net/netfilter/nf_nat_core.c:851:9: sparse: incompatible types in comparison expression (different address spaces) >> net/netfilter/nf_nat_core.c:836:9: sparse: dereference of noderef expression -- >> net/netfilter/nf_conntrack_netlink.c:1437:20: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile *p @@ got struct nf_nat_hoovoid const volatile *p @@ net/netfilter/nf_conntrack_netlink.c:1437:20: expected void const volatile *p net/netfilter/nf_conntrack_netlink.c:1437:20: got struct nf_nat_hook *[noderef] <asn:4>*<noident> >> net/netfilter/nf_conntrack_netlink.c:1437:20: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile *p @@ got struct nf_nat_hoovoid const volatile *p @@ net/netfilter/nf_conntrack_netlink.c:1437:20: expected void const volatile *p net/netfilter/nf_conntrack_netlink.c:1437:20: got struct nf_nat_hook *[noderef] <asn:4>*<noident> net/netfilter/nf_conntrack_netlink.c:1437:20: sparse: incompatible types in comparison expression (different address spaces) net/netfilter/nf_conntrack_netlink.c:1589:34: sparse: incompatible types in comparison expression (different address spaces) net/netfilter/nf_conntrack_netlink.c:3014:29: sparse: incorrect type in argument 1 (different address spaces) @@ expected char const *<noident> @@ got char [noderchar const *<noident> @@ net/netfilter/nf_conntrack_netlink.c:3014:29: expected char const *<noident> net/netfilter/nf_conntrack_netlink.c:3014:29: got char [noderef] <asn:4>*<noident> net/netfilter/nf_conntrack_netlink.c:868:36: sparse: context imbalance in 'ctnetlink_dump_table' - unexpected unlock include/linux/rcupdate.h:686:9: sparse: context imbalance in 'ctnetlink_parse_nat_setup' - unexpected unlock vim +836 net/netfilter/nf_nat_core.c 810 811 static int __init nf_nat_init(void) 812 { 813 int ret, i; 814 815 /* Leave them the same for the moment. */ 816 nf_nat_htable_size = nf_conntrack_htable_size; 817 if (nf_nat_htable_size < CONNTRACK_LOCKS) 818 nf_nat_htable_size = CONNTRACK_LOCKS; 819 820 nf_nat_bysource = nf_ct_alloc_hashtable(&nf_nat_htable_size, 0); 821 if (!nf_nat_bysource) 822 return -ENOMEM; 823 824 ret = nf_ct_extend_register(&nat_extend); 825 if (ret < 0) { 826 nf_ct_free_hashtable(nf_nat_bysource, nf_nat_htable_size); 827 pr_err("Unable to register extension\n"); 828 return ret; 829 } 830 831 for (i = 0; i < CONNTRACK_LOCKS; i++) 832 spin_lock_init(&nf_nat_locks[i]); 833 834 nf_ct_helper_expectfn_register(&follow_master_nat); 835 > 836 WARN_ON(nf_nat_hook != NULL); 837 RCU_INIT_POINTER(nf_nat_hook, &nat_hook); 838 839 return 0; 840 } 841 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
