On Saturday 2018-04-28 10:28, Yuri Gribov wrote:
>>> AM_CPPFLAGS = -I$(top_srcdir)/include
>>>-AM_CFLAGS = -Wall
>>>+AM_CFLAGS = -Wall @VISFLAGS@
>>
>> Only use @@ in .am files when you must (like, left-hand sides).
>> Otherwise, just ${VISFLAGS}.
>
>Ok, thanks. LDSFLAGS probly have to keep using @@ as it contains
>non-Bash friendly $(top_srcdir) syntax.
But ${top_srcdir} is expanded before getting to sh, hence no need
to eschew it.
>>>@@ -0,0 +1,4 @@
>>>+{
>>>+ global: nfnl*; nlif*;
>>>+ local: *;
>>>+};
>>
>> This ought to be
>>
>> NFNETLINK_1.0.1 {
>> global: <individual symbol list, no wildcards>...
>> local: *;
>> };
>
>TBH linker script might be an overkill here.
>Sole linker
>script purpose is to hide dummy symbols like __bss_start or _estart[...]
I see. Though, if there is a linker script, one might as well start
using versioned symbols too.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
