On Fri, Apr 27, 2018 at 11:23 PM, Yuri Gribov <tetra2005@xxxxxxxxx> wrote: > On Fri, Apr 27, 2018 at 9:10 PM, Florian Westphal <fw@xxxxxxxxx> wrote: >> It doesn't build for me: >> x86_64-pc-linux-gnu/bin/ld: cannot open linker script file ./nfnl.version: No such file or directory >> >> I need to move that file to src/. > > It turned out to be slightly more complicated because in-source and > out-source builds treat $srcdir differently (see e.g. comments here: > https://lists.gnu.org/archive/html/autoconf/2008-09/msg00008.html). > Common practice is to change it to $(top_srcdir) instead, which I did > in new version of patch. > > Note that Makefile.in's need to be regenerated as well, should I > attach them as well? > >> Otherwise i think its fine, perhaps add a >> 'Signed-off-by' tag and resubmit. > > Done. Sorry, minor update (nfnl_set_sequence_tracking, nfnl_unset_sequence_tracking weren't marked as extern so my regex didn't find them). -Y
Attachment:
0001-Hide-private-symbols-v3.patch
Description: Binary data
