Hi Florian,
Sorry I overlook this review, one comment below.
On Sat, Mar 31, 2018 at 06:13:49PM +0200, Florian Westphal wrote:
> Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx> wrote:
>
> > +struct xt_osf_opt {
> > + __u16 kind, length;
> > + struct xt_osf_wc wc;
> > +};
>
> Please leave xt_foo things in the xt_osf header.
>
> > +bool nf_osf_match(const struct sk_buff *skb, u_int8_t family,
> > + int hooknum, struct net_device *in, struct net_device *out,
> > + const struct xt_osf_info *info, struct net *net);
>
> This is the only thing that should be in the new header file.
> (the enum can probably be in nf_osf.c).
>
> > --- a/include/uapi/linux/netfilter/xt_osf.h
> > +++ b/include/uapi/linux/netfilter/xt_osf.h
>
> Again, DO NOT change this file.
> This is exposed to userspace, anything that changes here could break
> compile of user programs that include xt_osf.h.
Hm, he can move it to the new uapi nf_osf.h, then use defines, right?
I mean, this structure layouts will be needed to load OSF fingerprints
to nftables too, and it would be ugly if we depend on the xt_osf.h
file.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
