Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx> wrote:
> +struct xt_osf_opt {
> + __u16 kind, length;
> + struct xt_osf_wc wc;
> +};
Please leave xt_foo things in the xt_osf header.
> +bool nf_osf_match(const struct sk_buff *skb, u_int8_t family,
> + int hooknum, struct net_device *in, struct net_device *out,
> + const struct xt_osf_info *info, struct net *net);
This is the only thing that should be in the new header file.
(the enum can probably be in nf_osf.c).
> --- a/include/uapi/linux/netfilter/xt_osf.h
> +++ b/include/uapi/linux/netfilter/xt_osf.h
Again, DO NOT change this file.
This is exposed to userspace, anything that changes here could break
compile of user programs that include xt_osf.h.
> +config NF_OSF
> + tristate '"osf" Passive OS fingerprint match'
> + depends on NETFILTER_ADVANCED && NETFILTER_NETLINK
No need for depends here.
> if NF_TABLES_NETDEV
>
> config NF_DUP_NETDEV
> @@ -1377,6 +1381,7 @@ config NETFILTER_XT_MATCH_NFACCT
> config NETFILTER_XT_MATCH_OSF
> tristate '"osf" Passive OS fingerprint match'
> depends on NETFILTER_ADVANCED && NETFILTER_NETLINK
> + select NF_OSF
This looks okay.
> --- a/net/netfilter/xt_osf.c
> +++ b/net/netfilter/xt_osf.c
> @@ -1,20 +1,3 @@
> -/*
> - * Copyright (c) 2003+ Evgeniy Polyakov <zbr@xxxxxxxxxxx>
> - *
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, see <http://www.gnu.org/licenses/>.
> - */
Please do not blindly delete copyright statements.
Otherwise this seems ok but please compile test changes,
run scripts/checkpatch.pl and watch for compiler warnings.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
