Hi Florian, On Wed, Feb 28, 2018 at 04:33:05PM +0100, Florian Westphal wrote: > Phil Sutter <phil@xxxxxx> wrote: > > While revisiting all of them, clear a few oddities as well: > > > > - There's no point in marking empty fall through cases: They are easy to > > spot and a common concept when using switch(). > > NACK, sorry. There a source-code checkers that flag this > (they have heuristics to detect such comments). > > I agree with the rest and would apply the patch w.o. the first hunk, > no need to resend. Initial motivation for this review came from a covscan report, so this patch is actually to make those static code checkers happy, not the other way around. :) Regarding empty fall through (which seems to be the reason for your NACK): There was but a single fall through comment for an empty case in the whole code, and there are literally hundreds of them. Covscan didn't complain about those, hence why I think even from that perspective the single one is pointless. Cheers, Phil -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
